cluster features describe: one row per feature, with what the level means - #79
Merged
Merged
Conversation
kfake stores client metrics subscriptions now, so an alter no longer answers INVALID_REQUEST. The tests create one, read it back through list and describe, fail one on a bad interval, and delete it; the walkthrough seeds a subscription so list and describe have rows.
The table was SUPPORTED rows then FINALIZED rows, four columns each, with the finalized level repeated as both MIN and MAX. It is now one row per feature: SUPPORTED-MIN, SUPPORTED-MAX, FINALIZED, EPOCH, and a DESCRIPTION of the finalized level from kversion, with the KIP to search for. A feature the cluster has not enabled is at level 0; a broker that has not learned the cluster's levels prints them unknown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cluster features describeprinted SUPPORTED rows and then FINALIZED rows, four columns each, with the finalized level repeated as MIN and MAX. It is now one row per feature, the five numbers the Kafka script prints plus what the finalized level means, from kversion's new feature table (franz-go #1462):A feature the cluster has not enabled is at FINALIZED 0. A broker that has not learned the cluster's levels (epoch -1) prints FINALIZED, EPOCH, and DESCRIPTION as unknown. DESCRIPTION is free text in awk, like
misc errcode's.franz-go and kfake move to master, which also brings kfake's client metrics subscriptions:
client-metrics alter|describe|list|deletenow work againstkcl fake, and their tests and the walkthrough exercise them instead of pinning INVALID_REQUEST.Changelog
CHANGED
cluster features describeprints one row per feature: SUPPORTED-MIN, SUPPORTED-MAX, FINALIZED, EPOCH, DESCRIPTION; it printed SUPPORTED then FINALIZED rows of KIND NAME MIN-VERSION MAX-VERSION. JSON keys:feature,supported_min,supported_max,finalized,epoch,description.kcl fakestores client metrics subscriptions, soclient-metrics alter|describe|list|deletework against it.UPSTREAM
--as-version.