walkthrough: children skip the race runtime's exit sleep - #82
Merged
Merged
Conversation
Under -race the runtime sleeps a second before a process exits so a last race report can be written (GORACE atexit_sleep_ms, default 1000). Every kcl the walkthrough spawns is such a process, and it spawns about two hundred, so the walk took 90s of CI's 3m test step. The child environment sets atexit_sleep_ms=0: the walk now takes 9s under -race, 4s without.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every kcl the walkthrough spawns under
-racepaid the race runtime's one secondatexit_sleep_msbefore exiting; about two hundred children made the walk 90s of the 3m CI test step. The child environment now setsGORACE=atexit_sleep_ms=0(a child that ran one command has no race report pending). The walk is 9s under-race, 4s without. Test only, no behavior change.