Conversation
h3IndexToSplitLong parsed everything before the last 8 hex chars as the
upper word, so a string longer than 16 chars produced an upper value above
32 bits that was then truncated when passed to C. Extra leading digits
were silently dropped and, for example, isValidCell('1085283473fffffff')
returned true.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
h3IndexToSplitLongparses everything except the last 8 hex characters as the upper 32 bits, but it never checked that the result fits. For a string longer than 16 characters the upper value goes past 2^32 and is truncated when passed to the C library, so extra leading digits are silently dropped. For example,isValidCell('1085283473fffffff')returnstrue, andcellToLatLngreturns the location of85283473fffffff.This returns
[0, 0](like other invalid strings) when the upper part does not fit in 32 bits, so strings with leading zeros are still accepted. I added anisValidCellassertion that fails before the change, plus a changelog entry.yarn test-rawandyarn lintpass.