Skip to content

fix overlapping send and recv buffers #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mawi2017 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix overlapping send and recv buffers #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cilk/basic/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion cilk/src/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion cuda/basic/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion cuda/src/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,9 +487,10 @@ make_local_matrix(MatrixType& A)
int MPI_MY_TAG = 99;

nvtxRangeId_t r4=nvtxRangeStartA("MPI Communication");
std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion kokkos/src/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,10 @@ make_local_matrix(MatrixType& A)
// wait call below.
//
int MPI_MY_TAG = 99;
std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion mkl/basic/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion mkl/src/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion nvamg/basic/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion nvamg/src/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion openmp-opt-knl-memkind/src/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion openmp-opt-knl/basic/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion openmp-opt-knl/src/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion openmp-opt/basic/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion openmp-opt/src/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion openmp/basic/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion openmp/src/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion openmp45-opt/src/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion openmp45/basic/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion openmp45/src/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion qthreads/basic/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion qthreads/src/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion ref/basic/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down
3 changes: 2 additions & 1 deletion ref/src/make_local_matrix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,10 @@ make_local_matrix(MatrixType& A)
//
int MPI_MY_TAG = 99;

std::vector<GlobalOrdinal> tmp_recv_buffer(num_send_neighbors);
std::vector<MPI_Request> request(num_send_neighbors);
for(int i=0; i<num_send_neighbors; ++i) {
MPI_Irecv(&tmp_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_Irecv(&tmp_recv_buffer[i], 1, mpi_dtype, MPI_ANY_SOURCE, MPI_MY_TAG,
MPI_COMM_WORLD, &request[i]);
}

Expand Down