Skip to content

No way to tell if DANE part passed or not for cert usage 1 #136

@singpolyma

Description

@singpolyma

return tlsa.certUsage == TLSA.CertUsage.domainIssuedCertificate;

So for exmaple for 1 1 1 this checks that the DANE part passes, but then returns false because DANE is necessary but not sufficient in that case. We can know DANE didn't specifically fail because no exception is raised, but if DNSSEC fails entirely also we get a return of false with no exception raised, so there is no way to tell these apart.

Suggestion: return an int code, 0 for fully verified success, 1 for DANE passed but there's more to do, and -1 for no DANE found or checked at all. Something like that.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions