Skip to content

RR / RRSIG - #155

Merged
Flowdalic merged 3 commits into
MiniDNS:masterfrom
Flowdalic:rr
Oct 18, 2026
Merged

Flowdalic merged 3 commits into
MiniDNS:masterfrom
Flowdalic:rr

Conversation

@Flowdalic

Copy link
Copy Markdown
Collaborator

No description provided.

@coveralls

coveralls commented Oct 18, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 39122245560

Coverage increased (+0.8%) to 60.968%

Details

  • Coverage increased (+0.8%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 40 coverage regressions across 4 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

40 previously-covered lines in 4 files lost coverage.

File Lines Losing Coverage Coverage
org/minidns/record/Record.java 30 84.02%
org/minidns/dnsmessage/Question.java 6 82.09%
org/minidns/record/RRSIG.java 3 91.76%
org/minidns/record/UNKNOWN.java 1 90.91%

Coverage Stats

Coverage Status
Relevant Lines: 4775
Covered Lines: 3075
Line Coverage: 64.4%
Relevant Branches: 1794
Covered Branches: 930
Branch Coverage: 51.84%
Branches in Coverage %: Yes
Coverage Strength: 2.89 hits per line

💛 - Coveralls

Types unknown to MiniDNS were mapped to TYPE.UNKNOWN when parsing
records and questions, and later serialized using TYPE.UNKNOWN's value,
which is -1 and ends up as 65535 on the wire. Besides producing wrong
wire data, this caused records and questions with different unknown
types to be considered equal.

Record and Question now carry the binary type value in the new
typeValue field, which is used for serialization, equals(), hashCode()
and isAnswer(). The UNKNOWN payload now also stores the binary type
value, so that records created from an UNKNOWN payload, for example
when verifying a signature, keep the type value too. Unknown types are
rendered as "TYPE<value>" as per RFC 3597, using the new
TYPE.asString(int).
The type covered by an RRSIG was mapped to TYPE.UNKNOWN if it was
unknown to MiniDNS, and later serialized as -1, i.e., 65535. Since the
RRSIG RDATA, excluding the signature, is part of the signed data, the
signature of RRsets with an unknown type could never be verified.

RRSIG now carries the binary value of the covered type in the new
typeCoveredValue field, which is used when serializing the RRSIG.
Furthermore, DnssecClient now uses the binary type values to determine
the RRs covered by an RRSIG, instead of matching all RRs with an
unknown type.
Add all RR types permanently registered in the IANA "Resource Record
(RR) TYPEs" registry which were missing from TYPE: SMIMEA, ZONEMD,
SVCB, HTTPS, DSYNC, HHIT, BRID, UNECE, ISO, NXNAME, AVC, DOA, AMTRELAY,
RESINFO, WALLET, CLA, and IPN.
@Flowdalic
Flowdalic merged commit f964468 into MiniDNS:master Oct 18, 2026
2 checks passed
@Flowdalic
Flowdalic deleted the rr branch October 18, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants