Repository navigation
RR / RRSIG - #155
Merged
Merged
RR / RRSIG#155
Conversation
Coverage Report for CI Build 39122245560Coverage increased (+0.8%) to 60.968%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions40 previously-covered lines in 4 files lost coverage.
Coverage Stats
💛 - Coveralls |
Types unknown to MiniDNS were mapped to TYPE.UNKNOWN when parsing records and questions, and later serialized using TYPE.UNKNOWN's value, which is -1 and ends up as 65535 on the wire. Besides producing wrong wire data, this caused records and questions with different unknown types to be considered equal. Record and Question now carry the binary type value in the new typeValue field, which is used for serialization, equals(), hashCode() and isAnswer(). The UNKNOWN payload now also stores the binary type value, so that records created from an UNKNOWN payload, for example when verifying a signature, keep the type value too. Unknown types are rendered as "TYPE<value>" as per RFC 3597, using the new TYPE.asString(int).
The type covered by an RRSIG was mapped to TYPE.UNKNOWN if it was unknown to MiniDNS, and later serialized as -1, i.e., 65535. Since the RRSIG RDATA, excluding the signature, is part of the signed data, the signature of RRsets with an unknown type could never be verified. RRSIG now carries the binary value of the covered type in the new typeCoveredValue field, which is used when serializing the RRSIG. Furthermore, DnssecClient now uses the binary type values to determine the RRs covered by an RRSIG, instead of matching all RRs with an unknown type.
Add all RR types permanently registered in the IANA "Resource Record (RR) TYPEs" registry which were missing from TYPE: SMIMEA, ZONEMD, SVCB, HTTPS, DSYNC, HHIT, BRID, UNECE, ISO, NXNAME, AVC, DOA, AMTRELAY, RESINFO, WALLET, CLA, and IPN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.