Repository navigation
Tlsa - #156
Merged
Merged
Tlsa#156
Conversation
Coverage Report for CI Build 39278252833Coverage increased (+0.9%) to 63.116%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions96 previously-covered lines in 4 files lost coverage.
Coverage Stats
💛 - Coveralls |
DaneVerifier only considered TLSA RRs whose owner name equals the queried name. TLSA RRs provisioned via CNAMEs (RFC 6698 § A.2.1) were therefore ignored, and verifyCertificateChain() silently returned false, i.e., DANE was not used. DaneVerifier now de-aliases the queried name using the CNAME RRs of the authentic response, and queries the CNAME target if the response does not contain its TLSA RRs. The number of followed CNAMEs is limited to 16, which also guards against CNAME loops. Fixes MiniDNS#140.
This is the substitution performed for DNAME RRs (RFC 6672 § 2.2) and will be used to validate DNAME-synthesized CNAME RRs. Also remove the assertion on the length of the name in DnsName.toBytes(). If assertions were enabled, then it was triggered before validateMaxDnsnameLengthInOctets() could throw a DNSNameTooLongException, which is the intended behavior for too long names.
The CNAME RRs synthesized from DNAME RRs are not signed. Hence
DnssecClient threw a DnssecValidationFailedException ("Only some
records are signed!") for every answer involving a DNAME RR.
DnssecClient now considers an unsigned CNAME RR as valid if it is
consistent with a validated DNAME RR of the answer, that is, if its
owner name is below the owner name of the DNAME RR and its target is
the result of the DNAME substitution (RFC 6672 § 2.2, § 5.3.1).
If the DNSSEC validation of the TLSA response failed, DaneVerifier wrapped the DnssecValidationFailedException in a RuntimeException. RFC 6698 § 4.1 requires that a bogus TLSA response causes the TLS connection to be aborted. DaneVerifier now throws the new DaneCertificateException.DnssecValidationFailed, which, for example, causes DaneExtendedTrustManager to reject the server certificate. Other IOExceptions, e.g., network errors, are still wrapped in a RuntimeException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.