Repository navigation
[dnssec] Make JavaSecDigestCalculator thread-safe - #157
Merged
Flowdalic merged 1 commit intoOct 18, 2026
Merged
Conversation
JavaSecDigestCalculator used a single MessageDigest instance, which is not thread-safe. Since the calculators are shared via AlgorithmMap.INSTANCE, concurrent DNSSEC validations, e.g. resolving multiple names in parallel, raced on it. This produced wrong digests, often the digest of the empty input, or even exceptions thrown from within the MessageDigest implementation. As a result, DS digest comparisons of valid DNSKEYs failed intermittently with DigestComparisonFailedException, and NSEC3 owner name hashes could be wrong. Synchronize the access to the MessageDigest instance. Related to MiniDNS#132.
Coverage Report for CI Build 39124665706Coverage remained the same at 60.968%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaSecDigestCalculator used a single MessageDigest instance, which is not thread-safe. Since the calculators are shared via AlgorithmMap.INSTANCE, concurrent DNSSEC validations, e.g. resolving multiple names in parallel, raced on it. This produced wrong digests, often the digest of the empty input, or even exceptions thrown from within the MessageDigest implementation. As a result, DS digest comparisons of valid DNSKEYs failed intermittently with DigestComparisonFailedException, and NSEC3 owner name hashes could be wrong.
Synchronize the access to the MessageDigest instance.
Related to #132.