Repository navigation
[dnssec] Add DaneVerifier.daneVerify() returning DaneVerificationResult - #158
Merged
Merged
Conversation
Collaborator
Author
|
@singpolyma would that work for you? |
DaneVerifier.verifyCertificateChain() returned false if the TLSA response was not DNSSEC authenticated, if there were no usable TLSA records, and if a PKIX-EE (1) TLSA record matched the certificate. Hence callers were unable to tell whether DANE did not apply or whether the DANE verification was successful but PKIX validation is still required. The new daneVerify() methods return a DaneVerificationResult, which distinguishes between those cases. The existing boolean methods are now implemented on top of daneVerify(). Furthermore, a matching PKIX-EE TLSA record is now considered a match when deciding whether to throw a certificate mismatch exception. Previously, a TLSA RRset with a matching PKIX-EE record and a non-matching DANE-EE record resulted in a MultipleCertificateMismatchExceptions being thrown. Fixes MiniDNS#136.
Flowdalic
force-pushed
the
dane-verify
branch
from
October 18, 2026 12:06
70ac7db to
d12b967
Compare
Coverage Report for CI Build 39125938518Coverage increased (+1.4%) to 62.415%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions37 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DaneVerifier.verifyCertificateChain() returned false if the TLSA response was not DNSSEC authenticated, if there were no usable TLSA records, and if a PKIX-EE (1) TLSA record matched the certificate. Hence callers were unable to tell whether DANE did not apply or whether the DANE verification was successful but PKIX validation is still required.
The new daneVerify() methods return a DaneVerificationResult, which distinguishes between those cases. The existing boolean methods are now implemented on top of daneVerify().
Furthermore, a matching PKIX-EE TLSA record is now considered a match when deciding whether to throw a certificate mismatch exception. Previously, a TLSA RRset with a matching PKIX-EE record and a non-matching DANE-EE record resulted in a
MultipleCertificateMismatchExceptions being thrown.
Fixes #136.