Skip to content

[18.0][FIX] dms_field: Call the sanitizeDMSModel() method to obtain the appropriate model - #504

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
Tecnativa:18.0-fix-dms_field-TT64085
Aug 11, 2026
Merged

[18.0][FIX] dms_field: Call the sanitizeDMSModel() method to obtain the appropriate model#504
OCA-git-bot merged 1 commit into
OCA:18.0from
Tecnativa:18.0-fix-dms_field-TT64085

Conversation

@victoralmau

@victoralmau victoralmau commented Aug 11, 2026

Copy link
Copy Markdown
Member

Call the sanitizeDMSModel() method to obtain the appropriate model

Use case example: hr_dms_field

Related to #496

Please @pedrobaeza and @CarlosRoca13 can you review it?

@Tecnativa TT64085

@victoralmau
[FIX] dms_field: Call the sanitizeDMSModel() method to obtain the app…
743c0c7 
…ropriate model

Use case example: hr_dms_field

Related to OCA#496

TT64085
@OCA-git-bot

OCA-git-bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Hi @CarlosRoca13,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 18.0 milestone Aug 11, 2026
@pedrobaeza

pedrobaeza commented Aug 11, 2026

Copy link
Copy Markdown
Member

What sanitizeDMSModel does? Can you explain the problem? Which value returns before and after, for example.

@victoralmau

victoralmau commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

What sanitizeDMSModel does? Can you explain the problem? Which value returns before and after, for example.

Returns the “correct” model, which is used in hr_dms_field https://github.com/OCA/dms/blob/6da958550a511dfa382c1f4208d6024adb4a5d95/hr_dms_field/static/src/js/base/ dms_list_controller.esm.js#L12 to return hr.employee when a user with lower permissions is accessing their own employee (hr.employee.public).

The sanitizeDMSModel() method is already used elsewhere in the code.

CarlosRoca13
CarlosRoca13 approved these changes Aug 11, 2026
View reviewed changes

@CarlosRoca13 CarlosRoca13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense
👍 Thanks

pedrobaeza
pedrobaeza approved these changes Aug 11, 2026
View reviewed changes

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. Please put that info in the commit and PR comment next time from the beginning for being able to judge correctly and for future references.

For this one, let's not block it.

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-504-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit ba7d6fb into OCA:18.0 Aug 11, 2026
7 checks passed
@OCA-git-bot

OCA-git-bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 5332880. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
pedrobaeza deleted the 18.0-fix-dms_field-TT64085 branch August 11, 2026 13:22
@victoralmau victoralmau mentioned this pull request Aug 14, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes
+1 more reviewer
@CarlosRoca13 CarlosRoca13 CarlosRoca13 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:dms_field Module dms_field series:18.0

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

4 participants

@victoralmau @OCA-git-bot @pedrobaeza @CarlosRoca13