Stop PCSX2's duplicate frame setting from halving the framerate - #5
Open
Zulux91 wants to merge 1 commit into
Open
Stop PCSX2's duplicate frame setting from halving the framerate#5Zulux91 wants to merge 1 commit into
Zulux91 wants to merge 1 commit into
Conversation
SkipDuplicateFrames in PCSX2 means "do not present a frame identical to the last one". It is harmless there and on by default, which is why Settings defaults it to true. RPCS3 has no equivalent, and the bridge mapped it onto Enable Frame Skip, which means something completely different: drop one frame in every two, unconditionally. So every game presented at half the rate the guest asked for, on a fresh install, with nothing touched. It also made the frameskip row in the in-game menu useless, because applyToInner pushes the explicit frameskip first and this key afterwards, so this one always won no matter what you picked. Measured on Mirror's Edge, which asks for 30 flips a second. SurfaceFlinger was presenting 15.0 fps, one frame every 66.65 ms, rock steady. The RSX thread reported 0-5% load with six of eight cores idle, which is what sent me looking for a performance problem that was never there. With the mapping gone it sits at 30.0 fps, 33.32 ms. Dropped rather than remapped. Frameskip belongs to the explicit control, which is the one the user actually set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SkipDuplicateFrames in PCSX2 means "do not present a frame identical to the last one". It is harmless there and on by default, which is why Settings defaults it to true. RPCS3 has no equivalent, and the bridge mapped it onto Enable Frame Skip, which means something completely different: drop one frame in every two, unconditionally.
So every game presented at half the rate the guest asked for, on a fresh install, with nothing touched. It also made the frameskip row in the in-game menu useless, because applyToInner pushes the explicit frameskip first and this key afterwards, so this one always won no matter what you picked.
Measured on Mirror's Edge, which asks for 30 flips a second. SurfaceFlinger was presenting 15.0 fps, one frame every 66.65 ms, rock steady. The RSX thread reported 0-5% load with six of eight cores idle, which is what sent me looking for a performance problem that was never there. With the mapping gone it sits at 30.0 fps, 33.32 ms.
Dropped rather than remapped. Frameskip belongs to the explicit control, which is the one the user actually set.