Keep game data installs out of the library - #7
Open
Zulux91 wants to merge 1 commit into
Open
Conversation
A game data install looks exactly like an installed HDD game on disk, a PARAM.SFO next to USRDIR, so isPs3GameFolder accepted it. Every title you install data for therefore got a second tile that cannot boot, since game data holds no EBOOT. Skate 3 ships a 1.1 GB BLUS30464_INSTALL and showed up twice. CATEGORY is what tells them apart. GD is data, HG and DG are games. The native scanner already rejects these, because fetchGameInfo requires BOOTABLE and game data does not set it, but the folder path never opened the SFO at all. Reads just that one field rather than adding a general SFO parser. Nothing else needs it, and an unreadable or malformed file falls back to listing the folder, so the worst case is a stray tile and never a hidden game. ScanSchemaVersion goes up as the comment on cacheKey asks, since the cache stores the scan result and an existing one would keep serving the old entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A game data install looks exactly like an installed HDD game on disk, a PARAM.SFO next to USRDIR, so isPs3GameFolder accepted it. Every title you install data for therefore got a second tile that cannot boot, since game data holds no EBOOT. Skate 3 ships a 1.1 GB BLUS30464_INSTALL and showed up twice.
CATEGORY is what tells them apart. GD is data, HG and DG are games. The native scanner already rejects these, because fetchGameInfo requires BOOTABLE and game data does not set it, but the folder path never opened the SFO at all.
Reads just that one field rather than adding a general SFO parser. Nothing else needs it, and an unreadable or malformed file falls back to listing the folder, so the worst case is a stray tile and never a hidden game.
ScanSchemaVersion goes up as the comment on cacheKey asks, since the cache stores the scan result and an existing one would keep serving the old entry.