Fix console aspect ratio Auto resolving to 4:3 - #9
Open
Zulux91 wants to merge 1 commit into
Open
Conversation
Closes ARMSX2#3. setAspectRatio was written against ARMSX2's PS2 aspect enum, where index 1 was 4:3, and its javadoc still described that enum. ARMSX3's picker in RendererTab is a different one: 0 stretch, 1 Auto, 2 is 4:3 and 3 is 16:9. So the check for index 1 was matching Auto, and Auto is the default. Every game therefore came up in 4:3 on a fresh install, and RPCS3's own default for that node is 16:9. Setting the picker to 16:9 by hand worked, which is what the issue reports, because index 3 fell through to the 16:9 branch. Compare against index 2 instead, so only an explicit 4:3 selects 4:3 and everything else lands on 16:9. That also lines it up with the other writer of this node, writeGsToNative, which maps the same indices by name and already treated anything other than "4:3" as widescreen. Verified on an Odin 3: config.yml went from "Aspect ratio: 4:3" to "Aspect ratio: 16:9" with the picker left on Auto.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3.
setAspectRatio was written against ARMSX2's PS2 aspect enum, where index 1 was 4:3, and its javadoc still described that enum. ARMSX3's picker in RendererTab is a different one: 0 stretch, 1 Auto, 2 is 4:3 and 3 is 16:9. So the check for index 1 was matching Auto, and Auto is the default.
Every game therefore came up in 4:3 on a fresh install, and RPCS3's own default for that node is 16:9. Setting the picker to 16:9 by hand worked, which is what the issue reports, because index 3 fell through to the 16:9 branch.
Compare against index 2 instead, so only an explicit 4:3 selects 4:3 and everything else lands on 16:9. That also lines it up with the other writer of this node, writeGsToNative, which maps the same indices by name and already treated anything other than "4:3" as widescreen.
Verified on an Odin 3: config.yml went from "Aspect ratio: 4:3" to "Aspect ratio: 16:9" with the picker left on Auto.