docs: expand contributor workflow and PR template - #65
Merged
rosspeili merged 2 commits intoJul 30, 2026
Conversation
Contributor
|
Thanks for this as well @Kangwenqiao. Minor gaps / not blocking, but again, would incude in this PR to avoid follow ups
Ripple effects
Thanks again, this should cut down repeated review asks on tests, changelog, and git email. <3 |
Contributor
Author
|
Thanks for the detailed feedback. I addressed all of the suggested follow-ups in
Validation: documentation tests pass (19), and the full suite passes (77). |
Contributor
|
Thanks for this too @Kangwenqiao, this is beautiful and clean. LGTM and will merge after CI. Appreciate the quick turnaround. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CONTRIBUTING.mdaround contribution types, fork/upstream setup, scope and changelog expectations, local verification, verified git email, and the PR workflow.github/PULL_REQUEST_TEMPLATE.mdwith Rooms-specific change types and review checksThe guide uses Rooms paths, labels, and CI commands without carrying over Skillware registry or manifest-specific instructions.
Validation
uv run --with pytest --with-requirements requirements.txt python -m pytest tests/test_docs_hub.py -q(19 passed)uv run --with pytest --with-requirements requirements.txt python -m pytest -q(77 passed)uv run --with flake8 --with-requirements requirements.txt python -m flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics(0 errors)git diff --checkCHANGELOG.mdis unchanged because this PR documents contributor workflow without changing product behavior.Closes #47