feat: encoding auto-detection for non-UTF-8 archives - #44
Open
alex3236 wants to merge 2 commits into
Open
Conversation
- Use chardet (fallback to heuristic) to detect filename encoding - Switch _run_7zip from text=True to binary mode for raw bytes - Cache detected encoding per archive; pass -mcp to 7zz on extraction - Add python3-chardet to Flatpak manifest - Handle GBK, Shift-JIS, Big5, EUC-KR, CP1251 archives
Flatpak-builder sandbox has no network access, so pip3 install from PyPI fails with DNS resolution errors. Bundle the wheel as a local source instead.
|
|
1 similar comment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZIP archives store filenames using the system-local encoding of the OS where they were created, with no explicit encoding marker in the original format. The PKZip APPNOTE later introduced a "language encoding flag" (bit 11): when set to 1, filenames should be UTF-8; when 0, they use the local encoding. In practice, however, many implementations set the flag to 1 (because they "know" the filename is not plain ASCII) but still write the actual bytes in the local encoding — GBK, Shift-JIS, Big5, etc. This means the flag alone is not reliable for detecting encoding.
Previously 7zz output was decoded as UTF-8, so non-UTF-8 filenames would show as garbled text in the GUI. This PR detects the correct encoding before displaying the listing.
The detection flow works as follows: