This repository was archived by the owner on Apr 30, 2019. It is now read-only.
[WIP] merge upstream changes - #3
Open
caramcc wants to merge 39 commits into
Open
Conversation
* Add ruby 2.5.0 * Update older rubies to their latest releases * Update ruby/rails version exceptions for TravisCI
Fixes issues w/ Travis & Ruby 2.5 travis-ci/travis-ci#8978 (comment)
Update monetize to 1.8.0
Test on Rails 5.2
Update dependencies
if user added gem 'money-rails', '~>1' they may get error mentioned in RubyMoney#524 version which was fixed later (in 1.11.0)
This replaces all usages of `currency_as_string` with `currency.to_s`. `currency_as_string` is deprecated and will be removed in future versions.
…#552) * Only test against latest stable Rails versions * Update Mongoid specs to latest versions * Update .travis.yml * Exclude older Mongoid from newer rubies * Fix issues Mongoid5 failing spec * Combine specs for Mongoid 3, 4 & 5 * Add Mongoid 6 & 7 specs * Update supported Mongoid versions in README
e.g. when given a hash with :cents & :currency_iso keys as blank strings
This is required for older rubies, because new rubygems dropped ruby < 2.3 support
Fix failing master build
* Changes * Testing
* Add money_only_cents helper method * add spec for money_only_cents helper * use guard clause and remove empty branch in money_only_cents helper * test money_only_cents helper for monetizable_object and for <10 cents * add spec for money_only_cents with a non monetizable object * remove reduntant specs for money_only_cents
Was all rendered in one line otherwise which is confusing. Thanks for the quick release.
* Lock sqlite3 to ~> 1.3.6, so specs run smoothly * Lock i18n to < 1.5, so CI checks for older rubies pass
Support JSON serialization
caramcc
marked this pull request as ready for review
April 25, 2019 18:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.