fix(voice): zero-fill discovery packet, add IP discovery timeout (#205) - #19
Merged
Conversation
…labahaha#205) Found a couple of issues when it comes to using UDP (and one on voice in general): - If the UDP doesn't respond, the connection doesn't properly time that out - It *seems* that some voice servers may reject our packet if it has some garbage data from using `Buffer.allocUnsafe`, although I can't exactly pinpoint the voice servers doing this, it seems to be newer ones. - When using the VoiceConnectionManager to join channels, the disconnect error doesn't propogate up and rather always uses the "Disconnected" error. Also noticed that the voice connection timeout uses the gateway options instead of its own, and i didn't make a UDP timeout option yet. Maybe it is time to make a new `voice` options prop. --------- Co-authored-by: TTtie <me@tttie.cz>
taahamahdi
approved these changes
Nov 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-picked from projectdysnomia/dysnomia@160a849