Skip to content

fix(voice): zero-fill discovery packet, add IP discovery timeout (#205) - #19

Merged
Brainicism merged 1 commit into
devfrom
udp-fix
Nov 9, 2025
Merged

fix(voice): zero-fill discovery packet, add IP discovery timeout (#205)#19
Brainicism merged 1 commit into
devfrom
udp-fix

Conversation

@Brainicism

@Brainicism Brainicism commented Nov 9, 2025

Copy link
Copy Markdown
Owner

…labahaha#205)

Found a couple of issues when it comes to using UDP (and one on voice in
general):
- If the UDP doesn't respond, the connection doesn't properly time that
out
- It *seems* that some voice servers may reject our packet if it has
some garbage data from using `Buffer.allocUnsafe`, although I can't
exactly pinpoint the voice servers doing this, it seems to be newer
ones.
- When using the VoiceConnectionManager to join channels, the disconnect
error doesn't propogate up and rather always uses the "Disconnected"
error.

Also noticed that the voice connection timeout uses the gateway options
instead of its own, and i didn't make a UDP timeout option yet. Maybe it
is time to make a new `voice` options prop.

---------

Co-authored-by: TTtie <me@tttie.cz>
@Brainicism
Brainicism requested a review from taahamahdi November 9, 2025 03:11
@Brainicism
Brainicism merged commit 85d8917 into dev Nov 9, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants