Repository navigation
webui: complete WAN and multi-WAN controls - #154
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Complete the WAN, multi-WAN, and IPv6 network UI controls identified by the A2/A3 audits:
multiwan.dial_order,dial_wait, anddial_restorefields plus an immediate ordered redial action (POST net.dial_restore, operate scope).POST net.wan_mac, operate scope).wan[].modem.address.domains_fileselection and controlled.domainslist editing through the existingdns.filesAPI flow.Review follow-up
dial_restoreis empty oroff; it only redials late/out-of-order lines and returnsredialled,failed, andreason. The UI reports those values and disables the action without two configured dial-order WANs.tools/mock/modem-toggle.test.jsto CI.require_public_ipandrequire_public_ip_gapare now exposed in PPPoE WAN cards after #150 merged; #153 LAN/core changes are retained by the merge.Why
The WAN UI left dial order configuration read-only, allowed stale multi-WAN and IPv6 references to block applies, and omitted supported modem, multi-dial MAC, and policy domain-list controls. These changes make the supported backend configuration reachable from the network pages while preserving POST validation and token scopes.
Verification
node --check rootfs/www/ui/*.jspython3 tools/i18n.py checkcd mr && go vet ./...cd mr && go test -count=1 ./...sh tools/ci.sh—ALL CHECKS PASSEDruns/2026-10-17-minirouter/shots-ui-n1/(360px WAN/IPv6 and desktop multi-WAN).Refs A2 audit P1
dial_order,v6off,mr wan mac,modem.address,domains_file; A3-06.