Harden trainer lifecycle and v0.2 release provenance - #5
Merged
Conversation
DaoyuanLi2816
marked this pull request as ready for review
July 28, 2026 08:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPDTrainer.close()destructive and idempotent, including construction-failure cleanup, post-close guards, optimizer/target/backend teardown, and CUDA allocator releaseValidation
ruff check .;ruff format --check .;mypy src/miniverl(73 source files)close()returntwine check[train]wheel install completed demo, inspect, and report23323751318135484c06c043b1f9b9e7016dd89fThe published benchmark result remains byte-identical at SHA-256
53fc1d4d5b7adee09618d77ad62d4086ba56b78569832d6fc7c3bcd5c2695bbc.Release status
No tag or GitHub Release is created. PyPI publication remains externally blocked:
miniverlhas no PyPI project/trusted publisher yet, and this GitHub repository has nopypienvironment. The release workflow therefore remains hard-disabled withif: false.