Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"rehype-raw": "^7.0.0",
"sharp": "^0.32.6",
"viem": "^2.13.1",
"wagmi": "^2.12.12",
"wagmi": "^3.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade to wagmi v3 is a major version change. Snyk's own metadata for this PR indicates isBreakingChange: true, which means it will likely break the application due to incompatibilities with other dependencies.

Specifically, the project uses @rainbow-me/rainbowkit@^2.1.5, which is built for wagmi v2. Upgrading wagmi to v3 without also upgrading RainbowKit (and adapting the code to its new API) will cause compatibility issues and break your wallet connection functionality.

The vulnerability this PR aims to fix is in node-forge, a transitive dependency. A safer approach is to use Yarn's resolutions feature to force an upgrade of node-forge directly, without a major, breaking upgrade of wagmi.

I recommend reverting this change and instead adding a resolutions block to your package.json:

"resolutions": {
  "node-forge": ">=1.3.1"
}

After adding this, run yarn install to update your yarn.lock file.

Suggested change
"wagmi": "^3.0.0",
"wagmi": "^2.12.12",

"yaqrcode": "^0.2.1"
},
"devDependencies": {
Expand Down
Loading
Loading