Skip to content

example for cs reserved space - #40

Draft
oliveregger wants to merge 2 commits into
FHIR:masterfrom
ahdis:oe_iso3361_FHIR-50851
Draft

example for cs reserved space#40
oliveregger wants to merge 2 commits into
FHIR:masterfrom
ahdis:oe_iso3361_FHIR-50851

Conversation

@oliveregger

Copy link
Copy Markdown
Collaborator

see discussion to define an extension for CodeSystem to allow defining private code system spaces
FHIR-50851 and zulip

@grahamegrieve grahamegrieve left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this? I think I solved this differently?

@oliveregger

Copy link
Copy Markdown
Collaborator Author

I think it would be need when the extension is defined in the extension package? the proposed extension reserved-code-space from FHIR-50851 is not yet applied. If there is another way to solve it let me know.

@grahamegrieve

Copy link
Copy Markdown
Contributor

well, I'm pretty sure that I have test cases in the terminology server test cases for the use of the extended codes, and they're working

@oliveregger

oliveregger commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

You're right, the tests are there 3166-a … 3166-d in the bugs suite, covering that user-assigned codes validate, get displays from a supplement, and that a wrong display is only an information-level hint.

They pass because the reserved space is hardcoded in FHIRSmith tx/cs/cs-country.js

So once FHIR-50851 is applied and the extension is defined, having the reserved space declared in the CodeSystem itself would be still worth it. I adapted the extension to the latest resolution of FHIR-50851.

I'm not sure I know FHIRSmith code enough to support the extension fully in FHIRSmith, but would you
you be open for a PR to into consideration for the country tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants