Skip to content

Fix js module federation - #1

Open
Remcoman wants to merge 813 commits into
masterfrom
fix-js-module-federation
Open

Fix js module federation#1
Remcoman wants to merge 813 commits into
masterfrom
fix-js-module-federation

Conversation

@Remcoman

@Remcoman Remcoman commented Nov 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Owner

Current Behavior

Module federation for @nx/react does not work correctly in combination with the js option. When executed in spits out a combination of js and ts files. If you try to start up the project it will complain about a missing bootstrap file.

Expected Behavior

Module federation should work with @nx/react and the js option

Related Issue(s)

Fixes nrwl#20066

Changes

  • Output js files when options.js = true
  • Add tests for js=true and js=false option
  • Also made sure that tests for typescriptConfiguration=true and typescriptConfiguration=false are only focused on the configuration files

JamesHenry and others added 25 commits January 26, 2024 11:56
@JamesHenry
fix(release): only add nx-release-publish to public packages (nrwl#21338
c577f48 
)
@jaysoo
feat(webpack): simplify inferred webpack-cli command (nrwl#21340)
89c5188
@ndcunningham
fix(vite): PCV3 Plugin update to use resolveConfig (nrwl#21287)
bf6f78f
@Coly010
docs(core): update wording around guiding user to graph (nrwl#21348)
c2e0c3d
@fahslaj
fix(release): disable workspace changelogs in config when not valid (n…
9c81328 
…rwl#21341)
@jaysoo
fix(angular): update autoprefixer migration to the right file (nrwl#2…
4ed74a4 
…1363)
@jaysoo
feat(misc): hide unpublished links in project details view (nrwl#21362)
b4029e0
@FrozenPandaz
fix(core): do not create new targets from target defaults when packag… (
e1bb8bc 
nrwl#21365)
@FrozenPandaz @Cammisuli
fix(core): fix sending sigint to child tasks with the new psuedo tty … (
00dbd14 
nrwl#21369)

Co-authored-by: Jonathan Cammisuli <jon@cammisuli.ca>
@ndcunningham
fix(vite): PCV3 multiple targets (nrwl#21366)
79a7e79
@xiongemi
feat(core): pass down help to run-commands (nrwl#21331)
73d37cc
@xiongemi
fix(core): fix compilerOptions may not exist (nrwl#21364)
1bd2e0e
@FrozenPandaz
fix(core): fix conflicting types from merge conflict (nrwl#21371)
1040dbd
@JulMack
docs(core): fix typo (nrwl#21200)
391d226
@meeroslav
fix(repo): fix version calculation on nx-release (nrwl#21382)
17b09b9
@leosvelperez
fix(angular): update setup-ssr generator to support the outputPath ob…
c9f75ac 
…ject variant (nrwl#21385)
@fahslaj
docs(release): add recipe for publishing in github actions (nrwl#21370)
5369f5d
@YipingRuan
docs(vue): replace incorrect "React" in Vue doc. (nrwl#20930)
d08fe46 
Co-authored-by: Yiping <YipingRuan@users.noreply.github.com>
@Coly010
feat(remix): add nx welcome component (nrwl#21383)
911f8d6
@Coly010
fix(remix): tsconfigs were being incorrectly generated causing errors n…
1ea09ad 
…rwl#21002 (nrwl#21387)
@daiscog
fix(js): fix missing top-level dependencies in publishable libs (nrwl…
ec38a58 
…#17730)
@RyanParsley
docs(linter): fix typo (nrwl#20259)
2cb241a
@kdawgwilk
fix(devkit): fix extractLayoutDirectory typescript types to better re…
8274f34 
…flect allowed params and return value (nrwl#15339)
@AgentEnder
fix(core): address some wonkiness when merging command and run-comman…
c811be5 
…ds (nrwl#21315)
@fahslaj
fix(release): do not restart the daemon when skipLockFileUpdate is set (
69636ad 
nrwl#21389)
@jaysoo
jaysoo force-pushed the fix-js-module-federation branch from 768ac6e to b1e77f2 Compare January 29, 2024 19:14
@jaysoo
jaysoo force-pushed the fix-js-module-federation branch from b1e77f2 to f90b882 Compare January 29, 2024 20:24
JamesHenry and others added 18 commits February 9, 2024 18:09
@JamesHenry
fix(release): ensure nx release publish --graph only includes proje…
114faf8 
…cts with target (nrwl#21726)
@JamesHenry
fix(release): do not stop daemon in dry-run (nrwl#21743)
a568df2
@jaysoo
fix(js): babel preset should also check for JEST_WORKER_ID to transpi…
70ea82d 
…le to CJS (nrwl#21754)
@ndcunningham
fix(nextjs): Custom server should work with Crystal (nrwl#21736)
9683ebc
@JamesHenry
fix(core): static run one lifecycle should always print dependent tas…
5911ca6 
…k status, and output when verbose (nrwl#21720)
@xiongemi
feat(core): update swc/register (nrwl#21755)
f3cdce0
@FrozenPandaz
fix(testing): ensure cypress closes the web dev server (nrwl#21759)
2fe4396
@xiongemi
fix(playwright): fix include in tsconfig.json (nrwl#21730)
27faa7d
@leosvelperez
cleanup(misc): cleanup misc e2e tests (nrwl#21704)
e810f82
@ndcunningham
fix(nextjs): Svg should work when svgr is true in next config (nrwl#2…
b1d0294 
…1761)
@Coly010
fix(js): nx release-version resolve-version-spec should normalize fet…
11e139c 
…chSpec (nrwl#21710)
@leosvelperez
feat(angular): update jest-preset-angular version (nrwl#21776)
dbd0e7b
@FrozenPandaz
chore(repo): update nx to 18.1.0-beta.0 (nrwl#21772)
9ef99e7
@JamesHenry
docs(release): update programmatic API example (nrwl#21778)
f8523ed
@nixallover
docs(nx-cloud): update CI/CD examples on DTE page (nrwl#21762)
9663adc
@Coly010
fix(testing): jest should handle root jest.preset.cjs (nrwl#21746)
45f229f
@edbzn
fix(release): skip prompt for publish when no version created (nrwl#2…
ff143e4 
…1769)
@isaacplmann
docs(core): remove illustrated dte guide (nrwl#21781)
c8866ac
@xiongemi
xiongemi force-pushed the fix-js-module-federation branch from 6db5194 to 1831a80 Compare February 12, 2024 17:05
@xiongemi
xiongemi force-pushed the fix-js-module-federation branch from 1831a80 to 43fed36 Compare February 12, 2024 19:22
@xiongemi
xiongemi force-pushed the fix-js-module-federation branch from 43fed36 to 2d24ef8 Compare February 12, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Module federation using js is broken