Update Config to project_dir_path. Update utils for v4_global. Update… - #89
Open
burnettear wants to merge 1 commit into
Open
Update Config to project_dir_path. Update utils for v4_global. Update…#89burnettear wants to merge 1 commit into
burnettear wants to merge 1 commit into
Conversation
… non-gas/oil emis with v4 paths.
Contributor
Author
|
@nkruskamp reject this pull request. I used vscode git extension and it pushed to v4 instead of creating my v4_update_emis branch. I'm going to reach out on Teams |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 3 groups of files being updated:
1. config.py
The config file has been updated to include PROJECT_DIR_PATH from the .env. My .env is below:
PROJECT_DIR_PATH = "/Users/aburnette/Library/CloudStorage/OneDrive-SharedLibraries-EnvironmentalProtectionAgency(EPA)/Gridded CH4 Inventory - RTI 2024 Task Order/Task 2"
The updated config.py separates out V3 and V4 paths from the project_dir_path.
2. utils.py
The utils file was updated because emi files were failing, due to pulling tg_to_kt. Because utils.py was being imported from, utils was breaking because it pulls generic "global_data_path". I updated utils to include v4_paths and commented out global_data_dir_path for the moment. The long term fix would be to update functions in utils to use the correct path, or make the path an argument since there are now active V3 and V4 paths.
3. Non-oil/gas emi files
I updated all non-oil/gas emi files to include v4 paths, update to file dimensions for v4 (some InvDB and excel files changed formats), and ensured files write out to v4_emi dir correctly.