Repository navigation
Tags
Tags
Updating hashes Summary: GitHub commits: WhatsApp/erlang-language-platform@b4621dd facebookexperimental/edencommon@e30a4e0 facebookexperimental/rust-shed@bf905b5 facebookincubator/fizz@f6adeed bd99acb meta/fb303@bd91e45 meta/fbthrift@20538db meta/folly@25bb18f meta/hermes@44f5f48 meta/mvfst@843c47a meta/proxygen@463609d meta/wangle@6e9c0a9 Reviewed By: pranavcivi fbshipit-source-id: fb1e363012ea91588dbbb7392f91325e458711c7
Use `[[likely]]`/`[[unlikely]]` instead of whole-condition `FOLLY_LIK… …ELY` Summary: `FOLLY_LIKELY(cond)` and `FOLLY_UNLIKELY(cond)` wrap `__builtin_expect`. When the macro is the entire condition of an `if`, the C++20 `[[likely]]` and `[[unlikely]]` attributes on the branch say the same thing in standard C++. Rewrite those statements, for example `if (FOLLY_UNLIKELY(!ok))` becomes `if (!ok) [[unlikely]]`. Uses inside larger expressions and loop conditions are unchanged. No behavior change. Reviewed By: dtolnay Differential Revision: D130448441 fbshipit-source-id: a959a50f2368515dfe3d7b7faf8b2d8bfc892540
Remove unreachable returns in fbcode/ai_infra, fbcode/aiplatform and … …9 more (+23) Summary: Clang's `-Wunreachable-code-return` (reported by continuous lint as `clang-diagnostic-unreachable-code-return`) flags `return` statements that can never execute. This diff fixes 23 of them. Dead `return`s are deleted when they follow a statement that never completes normally (`throw`, `LOG(FATAL)`, `CHECK(false)`, `std::abort()`, `FAIL()`, ...) or a block whose every path already returns or throws (exhaustive `if`/`else`, `switch` with `default`, `try`/`catch`, `while (true)`). Behaviour is unchanged in every build mode. Where termination depends on the build mode (`DCHECK(false)`, `DLOG(FATAL)` and `assert(false)` abort only when `NDEBUG` is not defined), the fallback `return` is kept under `#ifdef NDEBUG`, so opt builds behave exactly as before and debug builds no longer carry a dead statement. Part of T294580822. Reviewed By: dtolnay Differential Revision: D127401217 fbshipit-source-id: de6f18156dcf41ecd51257e6e5a34e7cf7996200
Updating hashes Summary: GitHub commits: 6ac09ce meta/fb303@08e1a63 meta/fbthrift@c651dec meta/folly@c517b06 meta/mvfst@473f490 meta/proxygen@ee01105 meta/wangle@16e660e facebookexperimental/edencommon@5af78bb facebookexperimental/rust-shed@1cc2697 facebookincubator/fizz@7924cf1 Reviewed By: sdwilsh fbshipit-source-id: bfb4382715c82506fd868ed33062d2109330cd30
Updating hashes Summary: GitHub commits: WhatsApp/erlang-language-platform@5270c5b 0c320ad meta/fb303@b391ed9 meta/fbthrift@e5bba51 meta/folly@4dda9bd meta/mvfst@79aaf09 meta/proxygen@0d3feea pyrefly-org/pyrefly@30fbf77 meta/wangle@b134806 facebookexperimental/edencommon@8aa064a facebookexperimental/rust-shed@212e67d facebookincubator/fizz@2b9da06 Reviewed By: ajb85 fbshipit-source-id: 4b90bbebcf4e7a5a696841b25d70347865dc211b
Updating hashes Summary: GitHub commits: 1afde0f meta/fb303@8565417 meta/fbthrift@e2d2c89 meta/folly@68cabf0 meta/mvfst@2e6b5c9 meta/proxygen@1964792 pyrefly-org/pyrefly@02b812e meta/wangle@40a2fe0 facebookexperimental/edencommon@a151ad9 facebookexperimental/rust-shed@745d642 facebookincubator/fizz@bf0cef2 Reviewed By: pranavcivi fbshipit-source-id: a5c8a6062fa8d2ee907a898b3b40bac146ab372e
Updating hashes Summary: GitHub commits: 3dea588 meta/fb303@5a6f522 meta/fbthrift@e99f1d2 meta/folly@7914a31 meta/mvfst@af2fdf3 meta/proxygen@6490975 pyrefly-org/pyrefly@1d8dc92 meta/wangle@d5066eb facebookexperimental/rust-shed@8dbdf04 Reviewed By: kainanpeace666 fbshipit-source-id: a967a333156bfb964b09ca363e7500e856494629
Add an asynchronous transfer executor Summary: Add TransferExecutor, a framework-owned asynchronous transfer engine. Callers submit a DetachedItem together with the selected destination CacheComponent and Connector; the executor schedules accepted transfers on a configurable folly::CPUThreadPoolExecutor and tracks them with AsyncScope so shutdown can drain suspended work. Routing and selector policy remain in the framework rather than being frozen into bound callbacks. The executor is reusable for eviction and promotion and intentionally omits queue bounds, admission metrics, routing, and version checks; pool sizing remains caller policy. Reviewed By: rlyerly Differential Revision: D118363420 fbshipit-source-id: cea3c868e5d7569bc24e4d3109bc18029a335ac5
fbcode/cachelib/shm/ShmManager.cpp Reviewed By: rlyerly Differential Revision: D119648038 fbshipit-source-id: 396b516a333ab22f9ef85c17d9af8e813ecc46e7
Updating hashes Summary: GitHub commits: cce3e1d meta/fb303@9e155e5 meta/fbthrift@037bfb8 meta/mvfst@25047bc meta/proxygen@8d47d36 pyrefly-org/pyrefly@70f23e9 meta/wangle@cc3c744 facebookexperimental/edencommon@9035d18 facebookexperimental/rust-shed@a3e2ac1 facebookincubator/fizz@963f906 Reviewed By: sdwilsh fbshipit-source-id: bb1d63b95f6a1558e06aae3cf0066d8ed41dae8a
PreviousNext