Skip to content

Fix #850, prevent code execution on node init #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cheriimoya wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #850, prevent code execution on node init #1107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions mininet/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
import select
from distutils.version import StrictVersion
from re import findall
from shlex import quote
from subprocess import Popen, PIPE
from sys import exit # pylint: disable=redefined-builtin
from time import sleep
Expand Down Expand Up @@ -1410,6 +1411,7 @@ def __init__( self, name, inNamespace=False, command='controller',
ip, port = ip.split( ':' )
port = int( port )
self.ip = ip
assert isinstance( port, int )
self.port = port
self.protocol = protocol
Node.__init__( self, name, inNamespace=inNamespace,
Expand All @@ -1424,8 +1426,8 @@ def checkListening( self ):
raise Exception( "Error running telnet to check for listening "
"controllers; please check that it is "
"installed." )
listening = self.cmd( "echo A | telnet -e A %s %d" %
( self.ip, self.port ) )
listening = self.cmd( "echo A | telnet -e A %s %s" %
( quote( self.ip ), quote( self.port ) ) )
if 'Connected' in listening:
servers = self.cmd( 'netstat -natp' ).split( '\n' )
pstr = ':%d ' % self.port
Expand Down Expand Up @@ -1567,7 +1569,8 @@ def checkListening( self ):

def isListening( self, ip, port ):
"Check if a remote controller is listening at a specific ip and port"
listening = self.cmd( "echo A | telnet -e A %s %d" % ( ip, port ) )
listening = self.cmd( "echo A | telnet -e A %s %s" %
( quote( ip ), quote( port ) ) )
if 'Connected' not in listening:
warn( "Unable to contact the remote controller"
" at %s:%d\n" % ( ip, port ) )
Expand Down