Refactor the do_switch command to accept multiple switches#1112
Open
cheriimoya wants to merge 1 commit intomininet:masterfrom
Open
Refactor the do_switch command to accept multiple switches#1112cheriimoya wants to merge 1 commit intomininet:masterfrom
cheriimoya wants to merge 1 commit intomininet:masterfrom
Conversation
Contributor
Author
|
Closes #557 |
This commit changes the syntax of the switch command as follows
mininet> switch {start, stop} <switch name> [<switch name>] [...]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the syntax of the switch command as follows
mininet> switch {start, stop} <switch name> [<switch name>] [...]I tested this change:
This could be seen as a breaking change, because the old syntax is not accepted anymore.
The example commands above show that any start/stop commands are only executed if the "line" is correct.