All hopts/sopts/lopts options are ignored if some options are specified in addHost/addSwitch/addLink.#1189
Open
BlueShahriar wants to merge 1 commit intomininet:masterfrom
Open
All hopts/sopts/lopts options are ignored if some options are specified in addHost/addSwitch/addLink.#1189BlueShahriar wants to merge 1 commit intomininet:masterfrom
BlueShahriar wants to merge 1 commit intomininet:masterfrom
Conversation
…re specified in addHost/addSwitch/addLink methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you specify some options as arguments in Topo.addHost/addSwitch/addLink methods, then all the default options specified in Topo.hopts/sopts/lopts (Topo instance variables) are ignored. It would be more convenient if method options are updated by default options rather than ignoring all default options when some method options are provided. In cases where options are specified in both places, it would be better to prioritize the method options.