Fix installation on Ubuntu 24.04+ (PEP 668 and pep8 rename) - #1247
Open
satwikbasu wants to merge 3 commits into
Open
Fix installation on Ubuntu 24.04+ (PEP 668 and pep8 rename)#1247satwikbasu wants to merge 3 commits into
satwikbasu wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves installation issues on newer Linux distributions (Ubuntu 23.04+, Debian 12+) caused by PEP 668 and package renaming.
Changes:
util/install.sh: Added dynamic check forpycodestyle(replacespep8on newer systems).util/install.sh: Detects OS version and passes--break-system-packagesto pip if required.Makefile&util/install.sh: Updated to passPIP_OPTIONSto the Makefile so the final core installation step succeeds.Tested on Ubuntu 24.04.3 LTS. Fixes #1231.
P.S. This is my first open-source contribution ever and I hope it's significant enough to get merged to the master branch soon :)