Repository navigation
Conversation
|
Please join the github org via the slack channel so the CI runs for you. |
|
I'm in, thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mashehu
left a comment
There was a problem hiding this comment.
thanks for the contribution. we don't really recommend ungrouped parameters in nf-core, that's why this might have slipped through
mashehu
left a comment
There was a problem hiding this comment.
I made the tests a bit more like others in this repo.
Thanks for this contribution!
|
Thanks! |
|
actually found another place where we use this and combined the logic now. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LKxc9GKLwnyeV2jaZBxH9N
…arams_file.py Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LKxc9GKLwnyeV2jaZBxH9N
ef5d418 to
5c40725
Compare
|
feel free to merge, whenever you are happy 🙂 |
Merging this PR will improve performance by 30.76%3 warnings
Performance Changes
Tip Curious why performance improved? Comment Comparing |
PR checklist
CHANGELOG.mdis updateddocsis updatedThere's a bug in
generate_params_file: it writes the parameters from the schema's grouped definitions but skips properties defined at the top level of the schema.For a schema with
{"properties": {"input": {"type": "string", "default": "reads.csv"}}},nf-core pipelines create-params-filewrites the header and noinputentry. The commented template should haveinput: reads.csv.This writes the top-level properties after the groups, under "Other parameters", so flat and mixed schemas get all their parameters.
Test:
tests/pipelines/test_params_file_ungrouped.py(both schema drafts, grouped and hidden combinations) fails on dev, 8 of 8, and passes here; withtests/pipelines/test_params_file.pythat is 12 passed. The pre-commit hooks pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01LKxc9GKLwnyeV2jaZBxH9N