support ruby 3.x syntax by using ** descoping in new with hash inputs#43
Open
nic-lan wants to merge 1 commit intonikushi:masterfrom
Open
support ruby 3.x syntax by using ** descoping in new with hash inputs#43nic-lan wants to merge 1 commit intonikushi:masterfrom
new with hash inputs#43nic-lan wants to merge 1 commit intonikushi:masterfrom
Conversation
|
@nikushi |
|
@five510 i think we should fork this, the repo has gone without update for a while |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was trying to run ruby 3 in a project, which uses minipack.
unfortunately it seems that current way as the Commands::Base call the initialize method does not respect the new syntax.
This PR should fix it and still be compliant with recent versions of ruby.