Keep existing table descriptions — render quick links via header render hook - #18
Merged
Merged
Conversation
grafst
force-pushed
the
append-to-existing-descriptions
branch
from
August 8, 2026 11:19
bb78ac0 to
5bf8b40
Compare
niladam
force-pushed
the
append-to-existing-descriptions
branch
from
August 8, 2026 13:17
c35091f to
91fabbe
Compare
The render hook keeps a table's own description, which was the point of the change, but it built its markup as an HTML string inside the service provider. That markup now lives in a publishable Blade view, and the links reach it as structured data rather than pre-rendered anchors. Alongside that: - Require filament/tables ^3.0|^4.0|^5.0. The package has always imported Filament\Tables but never declared the dependency. TablesRenderHook and registerRenderHook() are identical across all three majors, so one code path covers them. - Raise the PHP floor to ^8.2, matching what Filament v4 and v5 require. 8.1 went end of life in December 2025 and cannot be tested with a current Pest. - Fix disableIf(). It stored the result of its closure instead of the closure, so it ran once while the provider booted - before auth() has a user to ask about - and the result was applied inverted, enabling where it should have disabled. It is now evaluated per render, which the render hook allows. - Add a Pest suite and a CI matrix covering PHP 8.2, 8.3 and 8.4 against Filament v3, v4 and v5.
niladam
force-pushed
the
append-to-existing-descriptions
branch
from
August 8, 2026 13:27
91fabbe to
64ec247
Compare
Adds UPGRADING.md covering the raised PHP floor, the new filament/tables requirement, the disableIf() behaviour change and the changed return types, and drops the leftover skeleton entry from the CHANGELOG. The CHANGELOG itself is generated on release by update-changelog.yml from the release body, so it is not edited by hand here.
Owner
|
Thank you for this @grafst I took the liberty to add some more improvements to this and and tagged a new release https://github.com/niladam/quick-links/releases/tag/v2.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tables that define their own
->description()currently lose the quick links entirely: the plugin sets the description inTable::configureUsing(), which runs before the resource's configuration chain, so a later->description()call replaces it (the README documents this limitation).This PR renders the links through the
tables::header.afterrender hook instead. The links now appear below the header for every table — including tables that have their own description, which is kept untouched. Resolution of the table happens viaLivewire::current(), soQuickLinks::build()keeps working unchanged, as dodisabled,enabled, and all config options.🤖 Generated with Claude Code