Skip to content

[bvl_feedback] Add missing French translations - #11110

Open
HachemJ wants to merge 2 commits into
aces:29.0-releasefrom
HachemJ:AddMissingTranslationsBvlFeedback
Open

[bvl_feedback] Add missing French translations#11110
HachemJ wants to merge 2 commits into
aces:29.0-releasefrom
HachemJ:AddMissingTranslationsBvlFeedback

Conversation

@HachemJ

@HachemJ HachemJ commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

This PR adds missing French translations to the Behavioural Feedback module, fixes typos, removes unused translation strings (e.g. “Input”, “Scoring Errors”) that are not referenced in the code, likely because they are database strings and require database translations instead.

Testing instructions (if applicable)

  1. git checkout HachemJ/AddMissingTranslationsBvlFeedback
  2. delete project/locale
  3. copy raisinbread/locale into project/locale
  4. run make dev (make sure it ran the msgfmt --use-fuzzy -o table.mo table.po commands)
  5. Please refer to the instructions in the corresponding issue if you’re unsure how to access this page
  6. Verify that the missing French translations have been added
  7. Verify that the typos were fixed

Link(s) to related issue(s)

@github-actions github-actions Bot added RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: bvl_feedback PR or issue related to bvl_feedback module Multilingual Any tasks related to making LORIS multilingual labels Jul 29, 2026
@HachemJ HachemJ added the 29.0.0 - Bugs Issues found during the release testing for 29.0.0 label Jul 29, 2026
@lapadulamichael

lapadulamichael commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@HachemJ I noticed 2 things

  1. When saving/creating a thread from another language, the exact translation is whats saved into the DB. This means that saving "Dans tous les domaines" in French will insert that into the DB and after no matter the language you will always see "Dans tous les domaines"
  2. The type still always saves in English which causes it to always appear in English
image image

@lapadulamichael lapadulamichael self-assigned this Aug 3, 2026
@lapadulamichael
lapadulamichael self-requested a review August 3, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: bvl_feedback PR or issue related to bvl_feedback module Multilingual Any tasks related to making LORIS multilingual RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants