Refonte cotisations avec Doctrine - #2324
Open
vgreb wants to merge 1 commit into
Open
Conversation
vgreb
force-pushed
the
refacto/membershipfee-doctrine
branch
2 times, most recently
from
July 26, 2026 13:41
b1546ac to
a3e7f34
Compare
vgreb
force-pushed
the
refacto/membershipfee-doctrine
branch
from
August 11, 2026 14:40
a3e7f34 to
f60feff
Compare
Mopolo
reviewed
Aug 11, 2026
| return 'COTIS-' . date('Y') . '-' . (is_numeric($result) ? (int) $result : 1); | ||
| } | ||
|
|
||
| public function updatePayment(int $id, int $typeReglement, string $informationsReglement): bool |
Contributor
There was a problem hiding this comment.
Si on remonte les utilisations de cette méthode, on trouve updatePayment dans \AppBundle\MembershipFee\MembershipFeeService qui n'est appelée qu'à un seul endroit :
web/sources/AppBundle/MembershipFee/OnlinePaymentHandler.php
Lines 42 to 46 in a3e7f34
Et cet endroit fait MembershipFeePayment::OnlinePayment->value donc on pourrait en profiter ici pour changer le int $typeReglement en MembershipFeePayment $typeReglement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.