Skip to content

refactor: drop noble helpers - #405

Merged
oritwoen merged 2 commits into
mainfrom
refactor/noble-helpers
Nov 17, 2026
Merged

oritwoen merged 2 commits into
mainfrom
refactor/noble-helpers

Conversation

@aeitwoen

@aeitwoen aeitwoen commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #401

A curve library was doing duty as the byte toolbox: this moves equalBytes and friends into src/utils/bytes.ts, where the big endian read exists once instead of three times.


Read this PR faster

@aeitwoen
aeitwoen requested a review from oritwoen as a code owner November 17, 2026 13:54
@aeitwoen aeitwoen self-assigned this Nov 17, 2026
@coldtea-pr-lens

coldtea-pr-lens Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
  • Redraw · drawn at e922a68, the branch has moved on

Architecture

Walkthrough of Vendor Noble curves byte and modular arithmetic utilities, in four steps

Read this PR faster

Inside the changed components — 2 views

Component view — Cryptographic utilities

Vendored modular arithmetic and expanded byte utilities replacing noble imports.

Architecture view of Component view — Cryptographic utilities in agntn/keys

Component view — Derivation callers

Derivation modules switching from noble utils to internal byte utilities.

Architecture view of Component view — Derivation callers in agntn/keys

Data flow

No data-flow sequence changed in this PR.


Review

1 finding addressed · reviewed e922a68

Tip

The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists
  • Click the link under each diagram to open it on a canvas you can zoom, pan and step through
  • The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change
  • Open a diagram on the canvas, then press W or click play to walk through the change one step at a time
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture… row. Drawing still runs as before
  • Set github.draw: on-demand in .github/pr-lens.yml and PR Lens stops drawing pull requests on its own. Comment @pr-lens draw on a pull request when you want that one drawn
  • Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works
  • After a push, tick Redraw to draw the latest commit
  • Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion
  • Set github.description: false in .github/pr-lens.yml to stop PR Lens adding buttons to your PR descriptions

Thanks for using PR Lens! It's free for OSS. If it helped, a star helps other teams find it.  Star PR Lens on GitHub

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T13:55:23.268324Z e922a68 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread src/utils/bytes.ts Resolved
@oritwoen
oritwoen merged commit 0923765 into main Nov 17, 2026
2 checks passed
@oritwoen
oritwoen deleted the refactor/noble-helpers branch November 17, 2026 14:14
@github-actions github-actions Bot mentioned this pull request Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace borrowed utility helpers

2 participants