Skip to content

refactor(chains): move Monero secrets - #399

Merged
oritwoen merged 1 commit into
mainfrom
refactor/monero-spend-curves
Nov 17, 2026
Merged

oritwoen merged 1 commit into
mainfrom
refactor/monero-spend-curves

Conversation

@oritwoen

@oritwoen oritwoen commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Closes #306

This moves Monero's spend key and signature nonces onto @agntn/curves, and the same steps for any scalar aren't free: getKeyPublic 0.45 to 0.86 ms, sign 0.71 to 1.35 ms in a local run.


Read this PR faster    Follow each request

@oritwoen oritwoen self-assigned this Nov 17, 2026
@coldtea-pr-lens

coldtea-pr-lens Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Architecture

Walkthrough of Use agntn/curves for all Monero point multiplication, in four steps

Read this PR faster


Data flow

Data flow diagram for agntn/keys at 90f9274

Follow each request


Review

✨ Nothing flagged · reviewed 90f9274


Tip

Set github.description: false in .github/pr-lens.yml to stop PR Lens adding buttons to your PR descriptions

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists
  • Click the link under each diagram to open it on a canvas you can zoom, pan and step through
  • The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change
  • Open a diagram on the canvas, then press W or click play to walk through the change one step at a time
  • The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture… row. Drawing still runs as before
  • Set github.draw: on-demand in .github/pr-lens.yml and PR Lens stops drawing pull requests on its own. Comment @pr-lens draw on a pull request when you want that one drawn
  • Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works
  • After a push, tick Redraw to draw the latest commit
  • Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion

Thanks for using PR Lens! It's free for OSS. If it helped, a star helps other teams find it.  Star PR Lens on GitHub

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T12:55:53.739683Z 90f9274 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@oritwoen
oritwoen merged commit 2558e73 into main Nov 17, 2026
4 checks passed
@oritwoen
oritwoen deleted the refactor/monero-spend-curves branch November 17, 2026 12:59
@github-actions github-actions Bot mentioned this pull request Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Monero's spend key math to @agntn/curves

1 participant