fix: the cnonce (client nonce) value used in http di... in cam.js - #450
Merged
agsh merged 1 commit intoJul 31, 2026
Merged
Conversation
Automated security fix generated by OrbisAI Security
Owner
|
@anupamme Hi! I never thought about this, thanks for the PR! |
agsh
added a commit
that referenced
this pull request
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
lib/cam.js.Vulnerability
V-001lib/cam.js:418Description: The cnonce (client nonce) value used in HTTP Digest authentication is generated using Math.random().toString(36), which is cryptographically insecure. Math.random() in JavaScript produces predictable pseudo-random numbers with insufficient entropy for security-critical operations. An attacker can predict or brute-force the cnonce value, potentially forging valid Digest authentication responses.
Evidence
Exploitation scenario: An attacker observes multiple authentication challenges from the target camera.
Scanner confirmation: multi_agent_ai rule
V-001flagged this pattern.Production code: This file is in the production codebase, not test-only code.
Threat Model Context
This is a Node.js library - vulnerabilities affect downstream consumers who use this package.
Changes
lib/cam.jsBehavior Preservation
The change is scoped to 1 file on the vulnerable path, and the project builds successfully with this change applied.
Verification
Automated security fix by OrbisAI Security