Skip to content

Skip disabled items in focus group navigation #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ai merged 1 commit into from
Jul 8, 2026
Merged

Skip disabled items in focus group navigation #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions focus-group.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ function getItems(target, group) {

function filterNested(allItems, group) {
return Array.from(allItems).filter(item => {
if (item.disabled || item.getAttribute('aria-disabled') === 'true') {
return false
}

let current = item.parentElement
while (current && current !== group) {
if (current.getAttribute('aria-hidden') === 'true') {
Expand Down Expand Up @@ -80,7 +84,7 @@ export function focusGroupKeyUX(options) {

let allItems = getItems(event.target, group)
let items = filterNested(allItems, group)
let index = Array.from(items).indexOf(event.target)
let index = items.indexOf(event.target)

let nextKey = 'ArrowDown'
let prevKey = 'ArrowUp'
Expand Down Expand Up @@ -114,7 +118,7 @@ export function focusGroupKeyUX(options) {
}
lastTyped = event.timeStamp

let found = Array.from(allItems).find(item => {
let found = items.find(item => {
return item.textContent
?.trim()
?.toLowerCase()
Expand Down
40 changes: 40 additions & 0 deletions test/focus-group.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,46 @@ describe('focus-group', () => {
equal(window.document.activeElement, items[3])
})

test('skips disabled items', async () => {
let window = new JSDOM().window
startKeyUX(window, [
hotkeyKeyUX(),
focusGroupKeyUX({
searchDelayMs: 100
})
])

window.document.body.innerHTML =
'<nav role="menu">' +
'<button role="menuitem">Home</button>' +
'<button role="menuitem" disabled>About</button>' +
'<button role="menuitem" aria-disabled="true">Blog</button>' +
'<button role="menuitem">Contact</button>' +
'</nav>'

let items = window.document.querySelectorAll('button')
items[0]!.focus()

press(window, 'ArrowDown')
equal(window.document.activeElement, items[3])

press(window, 'ArrowUp')
equal(window.document.activeElement, items[0])

press(window, 'End')
equal(window.document.activeElement, items[3])

press(window, 'Home')
equal(window.document.activeElement, items[0])

press(window, 'ArrowUp')
equal(window.document.activeElement, items[3])

await setTimeout(150)
press(window, 'b')
equal(window.document.activeElement, items[3])
})

test('supports RTL locales', () => {
let window = new JSDOM().window
startKeyUX(window, [focusGroupKeyUX()])
Expand Down