Skip to content

Add notebook analyzer and fix formatting - #476

Merged
Ekarerina-Ulyanova merged 7 commits into
mainfrom
feature/notebook_analyzer
Aug 10, 2026
Merged

Add notebook analyzer and fix formatting#476
Ekarerina-Ulyanova merged 7 commits into
mainfrom
feature/notebook_analyzer

Conversation

@Ekarerina-Ulyanova

@Ekarerina-Ulyanova Ekarerina-Ulyanova commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@Ekarerina-Ulyanova

Ekarerina-Ulyanova commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

cookbook_notebook_report.pdf

Пример обработки всего репозитория. Также предусмотрена возможность при запуске указывать пути к конкретным блокнотам для анализа.

@Ekarerina-Ulyanova
Ekarerina-Ulyanova requested a review from DRMPN July 29, 2026 19:11
DRMPN
DRMPN approved these changes Jul 29, 2026
View reviewed changes

@DRMPN DRMPN left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно еще в /docs добавить, чтобы API документацию поддерживать в актуальном состоянии.
Добавить пару докстрингов для основных функций.

В остальном lgtm.

edit: Можно Захара попросить агентную часть посмотреть.

Comment thread osa_tool/operations/analysis/notebook_report/models.py

@DRMPN DRMPN Jul 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может использовать Pydantic модели?

@DRMPN

DRMPN commented Jul 29, 2026

Copy link
Copy Markdown
Member

@codex review

@DRMPN DRMPN assigned DRMPN and Ekarerina-Ulyanova and unassigned DRMPN Jul 29, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 29, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95b3906da6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread osa_tool/operations/analysis/notebook_report/report_maker.py
Comment thread osa_tool/operations/analysis/notebook_report/analyzer.py Outdated
Comment thread osa_tool/operations/analysis/notebook_report/report_maker.py Outdated
Comment thread osa_tool/utils/arguments_parser.py Outdated
Comment thread osa_tool/operations/analysis/notebook_report/analyzer.py Outdated
Comment thread osa_tool/operations/analysis/notebook_report/analyzer.py Outdated
Comment thread osa_tool/operations/analysis/notebook_report/analyzer.py Outdated
Comment thread osa_tool/operations/analysis/notebook_report/analyzer.py Outdated
Comment thread osa_tool/run.py
Comment thread osa_tool/operations/analysis/notebook_report/analyzer.py
@DRMPN

DRMPN commented Jul 29, 2026

Copy link
Copy Markdown
Member

cookbook_notebook_report.pdf

Пример обработки всего репозитория. Также предусмотрена возможность при запуске указывать пути к конкретным блокнотам для анализа.

Я бы в будущем поправил оформление отчетов, чтобы сделать его более читаемым, сейчас немного глаза разбегаются.

@DRMPN DRMPN added the enhancement New feature or request label Jul 29, 2026
@Ekarerina-Ulyanova
Ekarerina-Ulyanova force-pushed the feature/notebook_analyzer branch from 95b3906 to 9daeaf8 Compare August 10, 2026 08:54
@Ekarerina-Ulyanova
Ekarerina-Ulyanova merged commit 268cbfe into main Aug 10, 2026
5 checks passed
@Ekarerina-Ulyanova
Ekarerina-Ulyanova deleted the feature/notebook_analyzer branch August 10, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@DRMPN DRMPN DRMPN approved these changes
@andreygetmanov andreygetmanov Awaiting requested review from andreygetmanov

Assignees

@Ekarerina-Ulyanova Ekarerina-Ulyanova

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ekarerina-Ulyanova @DRMPN