fix: correct exit code check for bun installation process#29
Merged
aklinker1 merged 2 commits intoaklinker1:mainfrom Jul 4, 2025
Merged
Conversation
Co-authored-by: renehernandez <7692501+renehernandez@users.noreply.github.com>
Owner
|
🤦 Maybe I was testing it and forgot to revert the change before committing? Who knows lol |
aklinker1
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #28 where bunv incorrectly reports "Failed to install Bun" despite successful installation.
Problem
The installation process was checking exit codes incorrectly in
src/vm.zigline 220:In Unix/Linux systems:
0means SUCCESS!= 0means FAILUREThe condition was backwards, treating successful installations (exit code 0) as failures.
Example of the Bug
Solution
Changed the condition from
== 0to!= 0to correctly detect failures:Now:
Changes
src/vm.zigline 220:==→!=Closes #28