Skip to content

change indentation, make multiline strings easier to read #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexlehm merged 1 commit into from
Jan 6, 2026
Merged

change indentation, make multiline strings easier to read #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions _test/action_plugin_googletagmanagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ public function test_google_tag_manager()
$value = $domElement->textContent;
} else {
// iframe src as subelement of noscript
$this->assertEquals("iframe", $domElement->firstChild->nodeName);
$value = $domElement->firstChild->getAttribute("src");
}
$patternFound = preg_match("!https://www.googletagmanager.com/.*id=.*$gtmValue!s", $value) === 1;
Expand Down
46 changes: 26 additions & 20 deletions action.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,30 +17,36 @@ public function register(EventHandler $controller)

public function addHeaders(&$event, $param)
{
$GTMID = $this->getConf(self::GTMID);
if (!$GTMID) return;
$GTMID = $this->getConf(self::GTMID);
if (!$GTMID) return;

$is_AW_tag = substr($GTMID, 0, 3) == 'AW-';
$is_AW_tag = substr($GTMID, 0, 3) == 'AW-';

if ($is_AW_tag) {
$event->data['script'][] = ['src' => "https://www.googletagmanager.com/gtag/js?id=" . $GTMID];
$event->data['script'][] = ['type' => 'text/javascript',
'_data' => "window.dataLayer = window.dataLayer || []; function gtag(){dataLayer.push(arguments);}" .
" gtag('js', new Date()); gtag('config', '" .
$GTMID .
"');"];
$script1 = "https://www.googletagmanager.com/gtag/js?id={$GTMID}";
$script2 = <<<EOT
window.dataLayer = window.dataLayer || []; function gtag(){dataLayer.push(arguments);}
gtag('js', new Date()); gtag('config', '{$GTMID}');";
EOT;

$event->data['script'][] = ['src' => $script1];
$event->data['script'][] = ['type' => 'text/javascript', '_data' => $script2];
} else {
$event->data['noscript'][] = ['_data' => '<iframe src="https://www.googletagmanager.com/ns.html?id=' .
$GTMID .
'" height="0" width="0" style="display:none;visibility:hidden"></iframe>'];
$event->data['script'][] = ['type' => 'text/javascript',
'_data' => "(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
})(window,document,'script','dataLayer','" .
$GTMID .
"');"];
$iframe = <<<EOT
<iframe src="https://www.googletagmanager.com/ns.html?id={$GTMID}"
height="0" width="0" style="display:none;visibility:hidden"></iframe>
EOT;

$script = <<<EOT
(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
})(window,document,'script','dataLayer','{$GTMID}');
EOT;

$event->data['noscript'][] = ['_data' => $iframe];
$event->data['script'][] = ['type' => 'text/javascript', '_data' => $script];
}
}
}
2 changes: 1 addition & 1 deletion plugin.info.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
base googletagmanager
author Alexander Lehmann
email alexlehm@gmail.com
date 2026-01-04
date 2026-01-06
name Google Tag Manager
desc Integrate a GTM tag into the wiki
url https://wiki.lehmann.cx/projects:dokuwiki_gtm
Loading