Repository navigation
Expand single-string slots as one attribute - #79
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attrsdocuments expansion of__slots__, but a valid single-string declaration such as__slots__ = 'value'is iterated character by character. ConsequentlyAttrs('obj')omitsobj.valueeven when it is populated.Normalize string slots to a one-item tuple before chaining with dictionary attributes. Add parameterized tests for string, tuple and list declarations, including attribute exclusion.
Validation on Python 3.13: original string-slot case fails (tuple/list pass); fixed regression: 3 passed. Full
pytest: 53 passed, 1 failed. The existingtest_sample[color]snapshot differs with the installed Pygments 2.21.0; the same failure reproduces on unmodified HEAD (color subset: 1 failed, 1 passed).git diff --checkpasses. Tests use synthetic objects/programs in an isolated task environment; no other Python version or CI result is claimed.