fix(terminal): make scroll wheel work again in alternate screen#42
Open
egertaia wants to merge 1 commit into
Open
fix(terminal): make scroll wheel work again in alternate screen#42egertaia wants to merge 1 commit into
egertaia wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41
Summary
_handleWheel/_handlePassiveWheelwhich are unreliable after the WebGL context swap\x1b[<64;col;rowM/\x1b[<65;col;rowM) when the app has enabled mouse tracking, falls back to arrow keys otherwiseRoot cause
xterm's built-in wheel forwarding fails in two cases:
_consumeWheelEventreturns 0 when render-service cell dimensions are temporarily unavailable (can happen after the WebGL renderer swap in v0.8.4+), causing the event to be silently droppedTest plan
🤖 Generated with Claude Code