fix(terminal): make scroll wheel work again in alternate screen#42
Merged
Merged
Conversation
This was referenced Jun 19, 2026
amirlehmam
added a commit
that referenced
this pull request
Jun 20, 2026
…close (fixes #47) Resolved overlap with PR #42 in useTerminal.ts: unified the wheel handler so it always takes ownership on the capture phase (alt-buffer ownership + arrow-key fallback from #42, reliable surfaceMouseEnabled signal + pre-attach resize handling from #48). Extracted the wheel handler and initial/deferred resize into module-level helpers to keep the mount effect within complexity limits.
Owner
|
Merged and shipped in v0.8.8 🚀 Thanks @kevmtt! Your alt-buffer ownership fix (#41) is the foundation of the unified wheel handler — I merged it together with #48 (the webview/tmux case). Since the handler now always takes ownership on the capture phase, the SGR-vs-arrow-keys decision uses #48's remount-safe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41
Summary
_handleWheel/_handlePassiveWheelwhich are unreliable after the WebGL context swap\x1b[<64;col;rowM/\x1b[<65;col;rowM) when the app has enabled mouse tracking, falls back to arrow keys otherwiseRoot cause
xterm's built-in wheel forwarding fails in two cases:
_consumeWheelEventreturns 0 when render-service cell dimensions are temporarily unavailable (can happen after the WebGL renderer swap in v0.8.4+), causing the event to be silently droppedTest plan
🤖 Generated with Claude Code