fix: keep Markdown line breaks consistent with preview - #25
Open
stevenjoezhang wants to merge 1 commit into
Open
fix: keep Markdown line breaks consistent with preview#25stevenjoezhang wants to merge 1 commit into
stevenjoezhang wants to merge 1 commit into
Conversation
stevenjoezhang
marked this pull request as ready for review
July 29, 2026 17:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
markedoptions used for comment creation and admin editsgfm: trueandbreaks: trueto match the widget previewRoot cause
The widget preview enables
breaks: true, but the backend previously calledmarked.parse()without that option. A single newline therefore appeared as a line break in preview but was collapsed to whitespace after the comment was saved or edited.Impact
New and edited comments now preserve single newlines consistently with the preview. The API schema and XSS sanitization behavior are unchanged. This patch does not migrate existing comment records.
Validation
./node_modules/.bin/vitest --run(4 files, 11 tests passed)git diff --checktsc --noEmitstill reports the repository's existing errors intelegramSettings.tsand the existingxss.whiteListtypings in the two comment handlers; this patch introduces no additional type errors.