fix: align comment post URL schema and imports - #28
Open
stevenjoezhang wants to merge 1 commit into
Open
Conversation
stevenjoezhang
marked this pull request as ready for review
July 30, 2026 03:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
post_urlcolumn to the canonicalCommentschemapost_urlthrough comment and full-backup importspost_urlcompatible by importingNULLRoot cause
The comment API already reads, writes, and edits
Comment.post_url, and the deployment migration can add it, but the canonical schema and runtime schema check did not guarantee that the column existed. Import paths also dropped the value during backup round trips.Compatibility
The migration is additive and idempotent. Existing rows keep
NULL, databases already containing the column are unchanged, and older backup payloads remain supported.Validation
./node_modules/.bin/vitest run(5 files, 15 tests passed)git diff --checktsc --noEmitstill reports the six pre-existing errors covered by #26; this change introduces no additional TypeScript errors.