Skip to content

fix: align comment post URL schema and imports - #28

Open
stevenjoezhang wants to merge 1 commit into
anghunk:mainfrom
stevenjoezhang:agent/fix-comment-post-url
Open

fix: align comment post URL schema and imports#28
stevenjoezhang wants to merge 1 commit into
anghunk:mainfrom
stevenjoezhang:agent/fix-comment-post-url

Conversation

@stevenjoezhang

Copy link
Copy Markdown

Summary

  • add the nullable post_url column to the canonical Comment schema
  • make the runtime schema check add the column to existing databases when needed
  • preserve post_url through comment and full-backup imports
  • keep older backups without post_url compatible by importing NULL

Root cause

The comment API already reads, writes, and edits Comment.post_url, and the deployment migration can add it, but the canonical schema and runtime schema check did not guarantee that the column existed. Import paths also dropped the value during backup round trips.

Compatibility

The migration is additive and idempotent. Existing rows keep NULL, databases already containing the column are unchanged, and older backup payloads remain supported.

Validation

  • ./node_modules/.bin/vitest run (5 files, 15 tests passed)
  • git diff --check

tsc --noEmit still reports the six pre-existing errors covered by #26; this change introduces no additional TypeScript errors.

@stevenjoezhang
stevenjoezhang marked this pull request as ready for review July 30, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant