Shouldnt these tokens be private? :P#1
Open
astuvan wants to merge 1 commit into
Open
Conversation
I saw your waiter project, and thought it was really cool! I tried to build it, but realised that these tokens were not removed. I am not sure, but are not those supposed to be private?
Author
|
Idk about the phone numbers as well, if they also should be private? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw your waiter project, and thought it was really cool! I tried to build it, but realised that these tokens were not removed. I am not sure, but are not those supposed to be private?