fix(modules): pass inputs to NixOS-integrated home-manager - #400
Open
github-actions[bot] wants to merge 1 commit into
Open
fix(modules): pass inputs to NixOS-integrated home-manager#400github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Commit 2f8b55c added extraSpecialArgs = {inherit inputs;} to the standalone homeConfigurations in dev.nix, but home.nix is also imported by the NixOS-integrated home-manager module in lib.nix, which was not given inputs. Since home.nix now references inputs.nixpkgs-unstable, every host build failed with `error: attribute 'inputs' missing`. Add home-manager.extraSpecialArgs = {inherit inputs;} to homeManagerModulesFor so inputs is available inside home.nix. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
The Build & Cache workflow failed on master for every host (pegasus, blackbird, galactica, basestar, raider, router) with:
Classification: real code bug (not transient CI infra) — the same eval error hit all hosts.
Root cause
Commit
2f8b55c("home: pass inputs to home-manager, use unstable zoxide…") introducedpkgs-unstable = import inputs.nixpkgs-unstable {…}inhome/home.nix, making the module depend on theinputsspecial arg.It correctly added
extraSpecialArgs = {inherit inputs;}to the standalonelegacyPackages.homeConfigurations.arosenfeldinflake-modules/dev.nix— buthome/home.nixis also imported by the NixOS-integrated home-manager module inflake-modules/lib.nix(homeManagerModulesFor→home-manager.users.arosenfeld = import ../home/home.nix). NixOSspecialArgsare not forwarded to home-manager user modules, and nohome-manager.extraSpecialArgswas set there, soinputswas undefined for everynixosConfigurations.<host>build.Fix
Add
home-manager.extraSpecialArgs = {inherit inputs;};tohomeManagerModulesForinflake-modules/lib.nix, mirroring the working pattern already used for the standalone home config indev.nix.Testing
No Nix toolchain is available in the CI-fix environment, so this is a log-based fix. The change is a one-line addition that mirrors the exact pattern already proven to work in
dev.nix, and matches alejandra formatting used elsewhere in the file. CI on this PR will confirm all hosts build.🤖 Generated with Claude Code