Expose GMM default calibration controls - #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ongoing_exploration_period,max_components, andmin_elite_samplesthrough Rust config, Python, YAML/CLI documentation, effective study configs, and checkpoints5,3, and1) and keep the existing five positional PythonGmm(...)arguments compatibleThis PR adds the controls needed for calibration. It does not adopt dynamic defaults, execute a calibration campaign, rerun paper benchmarks, or change the incumbent 5/3/1 setting values.
Validation
cargo fmt --all --checkcargo clippy --locked --workspace --all-features --all-targets -- -D warningscargo test --locked -p hola --tests --all-features(83 active unit + 105 integration tests)cargo test --locked --workspace --all-features(full workspace pass before the final restore-path hardening; the affected crate suites were rerun afterward)opt_engineandholaRUSTDOCFLAGS='-D warnings' cargo doc --locked --workspace --all-features --no-depsAll monitored local runs stayed below 1 GiB peak RSS and reported zero swap operations.