2c2s: Add metrics - #416
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a115f44880
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Installs the prometheus crate and defines metrics mirroring those of the existing server, with a handful of novel ones specific to the new server's architecture.
a115f44 to
f806e5c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f806e5cb2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| reported_ticks = times.challenge, | ||
| "challenge_time_mismatch", | ||
| ); | ||
| metrics::record_reported_time_mismatch(); |
There was a problem hiding this comment.
Count reported-time mismatches only after commit
When a finish-processing attempt detects a mismatch but a later database operation or the outer transaction commit fails, this increment remains even though the attempt is rolled back. The retriable finish run then executes this branch again, so one challenge can inflate challenge_server_reported_time_mismatch_total on every retry; return the mismatch outcome to the pipeline and record it only after a successful commit.
Useful? React with 👍 / 👎.
Installs the prometheus crate and defines metrics mirroring those of the existing server, with a handful of novel ones specific to the new server's architecture.