Allow -R to be passed *after* other global flags (-t and -D)#196
Open
janvrany wants to merge 1 commit intobolthole:masterfrom
Open
Allow -R to be passed *after* other global flags (-t and -D)#196janvrany wants to merge 1 commit intobolthole:masterfrom
-R to be passed *after* other global flags (-t and -D)#196janvrany wants to merge 1 commit intobolthole:masterfrom
Conversation
Using custom tags and a recursive `refresh` fails when creating snapshot with error: ERROR: unrecognized zrep subcommand -R This is because it executes something like ssh source_host zrep -t zrep_tag -R snaponly fs The `-R` flag comes after `-t` flag. However, `zrep` (prior this commit) required `-R` to be the fist flag. This commit moves the check for `-R` flag and initialization of `ZREP_R` to the same loop that checks for other global flags (currently `-t` and `-D`). This fixes the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using custom tags and a recursive
refreshfails when creating snapshot with error:This is because it executes something like
The
-Rflag comes after-tflag. However,zrep(prior this commit) required-Rto be the fist flag.This commit moves the check for
-Rflag and initialization ofZREP_Rto the same loop that checks for other global flags (currently-tand-D). This fixes the issue.